0 Replies Latest reply on Nov 26, 2015 5:03 AM by andrew.lukin_cogniance

    Possible bug in wiced_dct_restore_factory_reset()

    andrew.lukin_cogniance

      There is possible to make a wrong factory reset because of result check absence after wiced_waf_app_load() in WICED/platform/MCU/wiced_dct_internal_common.c.

       

      Original:

      wiced_waf_app_load( &app_header_locations[DCT_DCT_IMAGE_INDEX], &destination );
      wiced_dct_update_app_header_locations( OFFSETOF( platform_dct_header_t, apps_locations ), app_header_locations, apps_count );

       

      return WICED_SUCCESS;

       

      Despite of wiced_waf_app_load() response it always returns WICED_SUCCESS.

       

      Is it possible to change it to the following in a next WICED release? It will simplify a porting process.

       

         WICED_VERIFY(wiced_waf_app_load( &app_header_locations[DCT_DCT_IMAGE_INDEX], &destination ));

         WICED_VERIFY(wiced_dct_update_app_header_locations( OFFSETOF( platform_dct_header_t, apps_locations ), app_header_locations, apps_count ));


         return WICED_SUCCESS;