2 Replies Latest reply on Nov 23, 2016 2:17 AM by lcappelletti_1863061

    PDL git repo

    lcappelletti_1863061

      Hi there,

         

      I'd like to contribute back to PDL with a couple of simple patches for fixing warnings when compiling with GCC. Is there any git repository holding PDL source code?

         

      On the contrary, where can I send my patch to?

         

      Thanks,

         

      Lorenzo

         

       

         

      PS: at the moment, I'm using

         

      arm-none-eabi-g++.exe (GNU Tools for ARM Embedded Processors) 5.4.1 20160609 (release) [ARM/embedded-5-branch revision 237715]

        • 1. Re: PDL git repo
          user_1377889

          Welcome in the forum, Lorenzo.

             

          There is a thread for Software -> Community components which would be a good place for well-documented patches.

             

          I personally have a tendency to change my programs, so that all warnings are suppressed. Sometimes the warnings hint me that I have done something wrong which I need to correct. So what are your patches actually performing?

             

           

             

          Bob

          • 2. Re: PDL git repo
            lcappelletti_1863061

            I totally agree with you: I do dislike suppressing warnings. Nevertheless, some of them are very annoying.

               

            The warnings I'm suppressing are:

               
                  
            • missing quotes around #error message string
            •     
            • -Wunused-parameter
            •     
            • -Wunused-but-set-variable
            •     
            • -Wparentheses (because of v = v & ~x | y which becomes v = (v & ~x) | y)
            •     
            • -Wconversion
            •     
            • -Wpadded
            •