Strictly necessary cookies are on by default and cannot be turned off. Functional, Performance and Tracking/targeting/sharing cookies can be turned on below based on your preferences (this banner will remain available for you to accept cookies). You may change your cookie settings by deleting cookies from your browser. Then this banner will appear again. You can learn more details about cookies HERE.
Strictly necessary (always on)
Functional, Performance and Tracking/targeting/sharing (default off)
OK
Help
cancel
Turn on suggestions
Auto-suggest helps you quickly narrow down your search results by suggesting possible matches as you type.
Showing results for 
Search instead for 
Did you mean: 

WICED Studio Wi-Fi Combo

Anonymous
Not applicable
‎Oct 29, 2015 05:34 PM

unsafe strstr usage in ota_server daemon

Hi,

The buffer returned by wiced_packet_get_data is not NULL terminated.

So it should not use strstr for the request_string, it should use strnstr

instead.

A similar fix is already made for http server in new SDK,

Just want to point out the ota_server daemon needs fix as well.

BTW, in ota_server.c

I don't understand the purpose of below code snip, can someone explain it?

temp = request_string[ server->request.header_size ];

request_string[ server->request.header_size ] ='\0';

request_string[ server->request.header_size ] = temp;

0 Likes
Reply
0 Replies