bug in wwd_assert.c

Tip / Sign in to post questions, reply, level up, and achieve exciting badges. Know more

cross mob
grphc_1578046
Level 4
Level 4
10 likes received First like received First like given

In wwd_assert.c there is a bug the will cause the system to fail to build if the DEBUG and WPRINT_ENABLE_ERROR is enabled.

There are missing braces around the WPRINT_MACRO - current source is:

#define wiced_minor_assert( error_string, assertion )   do { if ( !(assertion) ) WPRINT_MACRO( error_string ); } while(0)

corrected source is:

#define wiced_minor_assert( error_string, assertion )   do { if ( !(assertion) ) WPRINT_MACRO( ( error_string ) ); } while(0)

This is on line 56 - Please correct for next release.

1 Solution
GauravS_31
Moderator
Moderator
Moderator
10 questions asked 250 solutions authored 250 sign-ins

Thank you for reporting this bug. I could reproduce the build error and the fix corrected the problem. I have raised a ticket and reported this bug internally and this should be corrected.

View solution in original post

6 Replies
GauravS_31
Moderator
Moderator
Moderator
10 questions asked 250 solutions authored 250 sign-ins

Thank you for reporting this bug. I could reproduce the build error and the fix corrected the problem. I have raised a ticket and reported this bug internally and this should be corrected.

grsr wrote:

Thank you for reporting this bug. I could reproduce the build error and the fix corrected the problem. I have raised a ticket and reported this bug internally and this should be corrected.

wiced-studio-5.0 does not include this fix.

I'm wondering why the fix keep getting lost in new sdk?

Seem we are keep wasting time in your internal communication.

grphc_1578046
Level 4
Level 4
10 likes received First like received First like given

STILL NOT in 5.1 release - WHAT DOES IT TAKE?

0 Likes

Let us check what release this will make it into.

I just cannot believe such trivial fix needs more than 6 months to merge.

Looking at the discussion thread, the time is mostly spent on message passing.

That discourages people to contribute fixes.

saching_06
Employee
Employee
10 replies posted 5 replies posted 10 questions asked

We appreciate your efforts in reporting this bug as well as a fix. Looks like it is fixed in WICED Studio 5.2. Here is the code from latest  wwd_assert.h file:

#define wiced_minor_assert( error_string, assertion ) do { if ( !(assertion) ) WPRINT_MACRO( ( error_string ) ); } while(0)

I agree it should not have taken so long to get this fix included in WICED Studio.

Thanks for making WICED better!